src/Client/PsrClickHouseClient.php (4)

57-64: Invalid default object in parameter; switch to nullable + fallback

Replace the default with nullable and fallback at call site.

-    public function executeQuery(string $query, SettingsProvider $settings = new EmptySettingsProvider()): void
+    public function executeQuery(string $query, ?SettingsProvider $settings = null): void
     {
         try {
-            $this->executeRequest($query, params: [], settings: $settings);
+            $this->executeRequest($query, params: [], settings: $settings ?? new EmptySettingsProvider());
         } catch (UnsupportedParamType) {
             absurd();
         }
     }

---

90-109: Invalid default object in parameter; switch to nullable + fallback

-    public function selectWithParams(
-        string $query,
-        array $params,
-        Format $outputFormat,
-        SettingsProvider $settings = new EmptySettingsProvider(),
-    ): Output {
+    public function selectWithParams(
+        string $query,
+        array $params,
+        Format $outputFormat,
+        ?SettingsProvider $settings = null,
+    ): Output {
@@
         $response = $this->executeRequest(
@@
-            settings: $settings,
+            settings: $settings ?? new EmptySettingsProvider(),
         );

---

206-211: Invalid default object in parameter; switch to nullable + fallback

-    public function insertWithFormat(
+    public function insertWithFormat(
         Table|string $table,
         Format $inputFormat,
         string $data,
-        SettingsProvider $settings = new EmptySettingsProvider(),
+        ?SettingsProvider $settings = null,
     ): void {
@@
-            $this->executeRequest(
+            $this->executeRequest(
@@
-                settings: $settings,
+                settings: $settings ?? new EmptySettingsProvider(),
             );

Also applies to: 221-227

---

233-239: Invalid default object in parameter; switch to nullable + fallback (and pass non-null to RequestSettings)

-    public function insertPayload(
+    public function insertPayload(
         Table|string $table,
         Format $inputFormat,
         StreamInterface $payload,
         array $columns = [],
-        SettingsProvider $settings = new EmptySettingsProvider(),
+        ?SettingsProvider $settings = null,
     ): void {
@@
-        $request = $this->requestFactory->initRequest(
+        $request = $this->requestFactory->initRequest(
             new RequestSettings(
                 $this->defaultSettings,
-                $settings,
+                $settings ?? new EmptySettingsProvider(),
             ),
             ['query' => $sql],
         );

Also applies to: 258-263

src/Client/PsrClickHouseAsyncClient.php (1)

35-36: Same note about “new” in parameter defaults as in the interface.

Constructor default new EmptySettingsProvider() also depends on PHP ≥ 8.1 support.

tests/Client/SelectTest.php (1)

172-172: LGTM: settings passed via provider.

Call now uses ArraySettingsProvider as intended. Optionally use a named argument for clarity: settings: new ArraySettingsProvider([...]).

src/Settings/EmptySettingsProvider.php (1)

9-12: Add PHPStan return annotation for consistency.

Mirror the interface’s phpstan alias on the concrete implementation to help static analysis.

-    public function get(): array
+    /** @phpstan-return Settings */
+    public function get(): array

tests/Client/Http/RequestSettingsTest.php (1)

18-20: LGTM: Merge semantics covered.

Test validates override (database) and retention (a/b). Consider adding a case with overlapping non-database keys to assert second provider precedence and, if booleans are allowed, a boolean setting to ensure proper handling.

src/Settings/ArraySettingsProvider.php (1)

15-18: Nit: add phpstan return type for stronger static typing.

Add an explicit phpstan return annotation to mirror the constructor param type alias.

-    public function get(): array
+    /** @phpstan-return Settings */
+    public function get(): array

src/Client/Http/RequestSettings.php (1)

12-13: Consider making settings readonly.

This is config assembled in ctor; mark as readonly to prevent accidental mutation.

-    public array $settings;
+    public readonly array $settings;

src/Client/PsrClickHouseAsyncClient.php (1)

26-26: Nit: remove unused phpstan import-type.

The imported Settings type alias isn’t referenced in this class.

-/** @phpstan-import-type Settings from SettingsProvider */

src/Client/ClickHouseClient.php (1)

19-19: Nit: remove unused phpstan import-type.

The Settings type alias isn’t referenced in this interface.

-/** @phpstan-import-type Settings from SettingsProvider */

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro